tgpholly/Binato
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

use forEach for itterating though received packets

Browse source
This commit is contained in:
Holly Stubbs 2022-01-04 04:42:26 +00:00
parent e65fc13419
commit 9e7ea3187b
Signed by: tgpholly
GPG key ID: B8583C4B7D18119E
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
server/serverHandler.js
View file

@ -166,13 +166,9 @@ module.exports = async function(req, res) {
const osuPacketReader = new osu.Client.Reader(requestData); const osuPacketReader = new osu.Client.Reader(requestData);
// Parse current bancho packet // Parse current bancho packet
const PacketData = osuPacketReader.Parse(); const PacketData = osuPacketReader.Parse();
// Loop through parsed packet data
for (let i = 0; i < PacketData.length; i++) {
// Get current packet
let CurrentPacket = PacketData[i];
// This is getting a little big, swap this out for mapped functions? // Go through each packet sent by the client
// Would require some standardisation PacketData.forEach(CurrentPacket => {
switch (CurrentPacket.id) { switch (CurrentPacket.id) {
case packetIDs.client_changeAction: case packetIDs.client_changeAction:
ChangeAction(PacketUser, CurrentPacket.data); ChangeAction(PacketUser, CurrentPacket.data);
@ -192,7 +188,7 @@ module.exports = async function(req, res) {
case packetIDs.client_pong: // Pretty sure this is just a client ping case packetIDs.client_pong: // Pretty sure this is just a client ping
// so we probably don't do anything here // so we probably don't do anything here
break; // It's probably just the client wanting to pull data down. break; // It's probably just the client wanting to pull data down. (That's exactly what it is)
case packetIDs.client_startSpectating: case packetIDs.client_startSpectating:
Spectator.startSpectatingUser(PacketUser, CurrentPacket.data); Spectator.startSpectatingUser(PacketUser, CurrentPacket.data);
@ -346,7 +342,7 @@ module.exports = async function(req, res) {
// Concat current user queue into response data // Concat current user queue into response data
responseData = Buffer.concat([responseData, PacketUser.queue], responseData.length + PacketUser.queue.length); responseData = Buffer.concat([responseData, PacketUser.queue], responseData.length + PacketUser.queue.length);
PacketUser.clearQueue(); PacketUser.clearQueue();
} });
} else { } else {
// User's token is invlid, force a reconnect // User's token is invlid, force a reconnect
consoleHelper.printBancho(`Forced client re-login (Token is invalid)`); consoleHelper.printBancho(`Forced client re-login (Token is invalid)`);