base/ReaderBase.ts

@@ -50,25 +50,4 @@ export class ReaderBase {
 	public readBool() {
 		return Boolean(this.readUByte());
 	}
-
-	public readShortString() {
-		const length = this.readUByte();
-		let text = "";
-
-		for (let i = 0; i < length; i++) {
-			text += String.fromCharCode(this.readUByte());
-		}
-
-		return text;
-	}
-
-	public readBytesAsString(bytesToRead:number) {
-		let text = "";
-
-		for (let i = 0; i < bytesToRead; i++) {
-			text += String.fromCharCode(this.readUByte());
-		}
-
-		return text;
-	}
 }

base/WriterBase.ts

@@ -76,19 +76,4 @@ export class WriterBase {
 
 		return this;
 	}
-
-	public writeStringAsBytes(text:string) {
-		let buffer;
-		if (this.resizable) {
-			buffer = getBufferClass().alloc(text.length);
-		} else {
-			buffer = this.buffer;
-		}
-
-		for (let i = 0; i < text.length; i++) {
-			buffer.writeUInt8(text.charCodeAt(i), i);
-		}
-
-		return this;
-	}
 }

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "bufferstuff",
-	"version": "1.5.0",
+	"version": "1.4.2",
 	"description": "A set of utility classes for reading and writing binary data in NodeJS and the browser",
 	"main": "./lib/index.js",
 	"types": "./lib/index.d.ts",
@@ -32,8 +32,9 @@
 	"devDependencies": {
 		"check-outdated": "^2.12.0",
 		"npm-run-all": "^4.1.5",
-		"terser": "^5.26.0",
-		"ts-node": "^10.9.2",
-		"typescript": "^5.3.3"
+		"terser": "^5.24.0",
+		"ts-loader": "^9.5.0",
+		"ts-node": "^10.9.1",
+		"typescript": "^5.2.2"
 	}
 }

readers/IReader.ts

@@ -9,8 +9,6 @@ export interface IReader {
 	readByte(): number,
 	readUByte(): number,
 	readBool(): boolean,
-	readShortString(): string,
-	readBytesAsString(bytesToRead:number): string,
 	readShort(): number,
 	readUShort(): number,
 	readInt(): number,
@@ -19,7 +17,7 @@ export interface IReader {
 	readULong(): bigint,
 	readFloat(): number,
 	readDouble(): number,
+	readShortString(): string,
 	readString(): string,
-	readShortsAsString(shortsToRead:number): string,
 	readString16(): string,
 }

readers/ReaderBE.ts

@@ -53,9 +53,20 @@ export class ReaderBE extends ReaderBase implements IReader {
 		return value;
 	}
 
+	public readShortString() {
+		const length = this.readUByte();
+		let text:string = "";
+
+		for (let i = 0; i < length; i++) {
+			text += String.fromCharCode(this.readUByte());
+		}
+
+		return text;
+	}
+
 	public readString() {
 		const length = this.readUShort();
-		let text = "";
+		let text:string = "";
 
 		for (let i = 0; i < length; i++) {
 			text += String.fromCharCode(this.readUByte());
@@ -66,7 +77,7 @@ export class ReaderBE extends ReaderBase implements IReader {
 
 	public readString16() {
 		const length = this.readUShort();
-		let text = "";
+		let text:string = "";
 
 		for (let i = 0; i < length; i++) {
 			text += String.fromCharCode(this.readUShort());
@@ -74,14 +85,4 @@ export class ReaderBE extends ReaderBase implements IReader {
 
 		return text;
 	}
-
-	public readShortsAsString(shortsToRead:number) {
-		let text = "";
-
-		for (let i = 0; i < shortsToRead; i++) {
-			text += String.fromCharCode(this.readUShort());
-		}
-
-		return text;
-	}
 }

readers/ReaderLE.ts

@@ -53,6 +53,17 @@ export class ReaderLE extends ReaderBase implements IReader {
 		return value;
 	}
 
+	public readShortString() {
+		const length = this.readUByte();
+		let text:string = "";
+
+		for (let i = 0; i < length; i++) {
+			text += String.fromCharCode(this.readUByte());
+		}
+
+		return text;
+	}
+
 	public readString() {
 		const length = this.readUShort();
 		let text:string = "";
@@ -74,14 +85,4 @@ export class ReaderLE extends ReaderBase implements IReader {
 
 		return text;
 	}
-
-	public readShortsAsString(shortsToRead:number) {
-		let text = "";
-
-		for (let i = 0; i < shortsToRead; i++) {
-			text += String.fromCharCode(this.readUShort());
-		}
-
-		return text;
-	}
 }

writers/IWriter.ts

@@ -11,17 +11,15 @@ export interface IWriter {
 	writeByte(value:number): IWriter,
 	writeUByte(value:number): IWriter,
 	writeBool(value:boolean|number): IWriter,
-	writeStringAsBytes(text:string): IWriter,
 	writeShort(value:number): IWriter,
 	writeUShort(value:number): IWriter,
 	writeInt(value:number): IWriter,
 	writeUInt(value:number): IWriter,
 	writeLong(value:number|bigint): IWriter,
-	writeULong(value:number|bigint): IWriter,
+	writeULong(value:number): IWriter,
 	writeFloat(value:number): IWriter,
 	writeDouble(value:number): IWriter,
 	writeShortString(text:string): IWriter,
 	writeString(text:string): IWriter,
 	writeString16(text:string): IWriter,
-	writeStringAsShorts(text:string): IWriter
 }

writers/WriterBE.ts

@@ -147,19 +147,4 @@ export class WriterBE extends WriterBase implements IWriter {
 
 		return this;
 	}
-
-	public writeStringAsShorts(text:string) {
-		let buffer:Buffer;
-		if (this.resizable) {
-			buffer = getBufferClass().alloc(text.length * 2);
-		} else {
-			buffer = this.buffer;
-		}
-
-		for (let i = 0; i < text.length; i++) {
-			buffer.writeUint16BE(text.charCodeAt(i), i);
-		}
-
-		return this;
-	}
 }

writers/WriterLE.ts

@@ -146,19 +146,4 @@ export class WriterLE extends WriterBase implements IWriter {
 
 		return this;
 	}
-
-	public writeStringAsShorts(text:string) {
-		let buffer:Buffer;
-		if (this.resizable) {
-			buffer = getBufferClass().alloc(text.length * 2);
-		} else {
-			buffer = this.buffer;
-		}
-
-		for (let i = 0; i < text.length; i++) {
-			buffer.writeUint16LE(text.charCodeAt(i), i);
-		}
-
-		return this;
-	}
 }